Skip to content

Predicate pushdown to sync #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 7, 2025
Merged

Predicate pushdown to sync #617

merged 12 commits into from
Oct 7, 2025
+2,060 −1,677

Conversation

kevin-dp
Copy link
Contributor

@kevin-dp kevin-dp commented Oct 1, 2025

This PR modifies tanstack DB to push down predicates to the sync layer.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a606756

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@tanstack/db Patch
@tanstack/angular-db Patch
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/react-db Patch
@tanstack/rxdb-db-collection Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch
todos Patch
@tanstack/db-example-react-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevin-dp kevin-dp mentioned this pull request Oct 1, 2025
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 1, 2025 •
edited
Loading

More templates

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@617

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@617

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@617

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@617

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@617

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@617

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@617

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@617

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@617

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@617

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@617

commit: a606756

@kevin-dp kevin-dp mentioned this pull request Oct 1, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025 •
edited
Loading

Size Change: +755 B (+1%)

Total Size: 75.9 kB

Filename Size Change
./packages/db/dist/esm/collection/index.js 3.31 kB +123 B (+3.87%)
./packages/db/dist/esm/collection/subscription.js 1.83 kB +183 B (+11.12%) ⚠️
./packages/db/dist/esm/collection/sync.js 1.65 kB +231 B (+16.28%) ⚠️
./packages/db/dist/esm/index.js 1.58 kB +23 B (+1.47%)
./packages/db/dist/esm/query/compiler/expressions.js 760 B +129 B (+20.44%) 🚨
./packages/db/dist/esm/query/compiler/order-by.js 1.21 kB +7 B (+0.58%)
./packages/db/dist/esm/query/live/collection-subscriber.js 1.92 kB +59 B (+3.17%)
ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/collection/change-events.js 943 B
./packages/db/dist/esm/collection/changes.js 1.01 kB
./packages/db/dist/esm/collection/events.js 660 B
./packages/db/dist/esm/collection/indexes.js 1.16 kB
./packages/db/dist/esm/collection/lifecycle.js 1.8 kB
./packages/db/dist/esm/collection/mutations.js 2.5 kB
./packages/db/dist/esm/collection/state.js 3.82 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 3.1 kB
./packages/db/dist/esm/indexes/auto-index.js 806 B
./packages/db/dist/esm/indexes/base-index.js 835 B
./packages/db/dist/esm/indexes/btree-index.js 2 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.21 kB
./packages/db/dist/esm/indexes/reverse-index.js 577 B
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.02 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 3.86 kB
./packages/db/dist/esm/query/builder/functions.js 615 B
./packages/db/dist/esm/query/builder/index.js 4.04 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 938 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.55 kB
./packages/db/dist/esm/query/compiler/group-by.js 2.04 kB
./packages/db/dist/esm/query/compiler/index.js 2.04 kB
./packages/db/dist/esm/query/compiler/joins.js 2.52 kB
./packages/db/dist/esm/query/compiler/select.js 1.28 kB
./packages/db/dist/esm/query/ir.js 785 B
./packages/db/dist/esm/query/live-query-collection.js 340 B
./packages/db/dist/esm/query/live/collection-config-builder.js 2.69 kB
./packages/db/dist/esm/query/optimizer.js 3.08 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 3 kB
./packages/db/dist/esm/utils.js 1.01 kB
./packages/db/dist/esm/utils/browser-polyfills.js 365 B
./packages/db/dist/esm/utils/btree.js 6.01 kB
./packages/db/dist/esm/utils/comparison.js 754 B
./packages/db/dist/esm/utils/index-optimization.js 1.73 kB

compressed-size-action::db-package-size

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 1.47 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 1.32 kB

compressed-size-action::react-db-package-size

@kevin-dp kevin-dp force-pushed the kevin/pred-pushdown-to-sync-db branch from aa2e623 to 2ae236f Compare October 6, 2025 12:17
@kevin-dp kevin-dp requested a review from samwillis October 6, 2025 14:59
samwillis
samwillis approved these changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this one merged. I'm sure things will come up as we work through the rest of the functionality, but this is a great foundation to build on.

@kevin-dp kevin-dp force-pushed the kevin/pred-pushdown-to-sync-db branch from 91ea051 to 3493f6d Compare October 7, 2025 09:33
@kevin-dp kevin-dp merged commit dd6cdf7 into main Oct 7, 2025
6 checks passed
@kevin-dp kevin-dp deleted the kevin/pred-pushdown-to-sync-db branch October 7, 2025 10:17
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwillis samwillis samwillis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-dp @samwillis